Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86f5469a25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| outputs: [ | ||
| /reset-form/i, | ||
| /Form cleared/i, | ||
| /(?:form-errors|full-name-error|Required)/i, |
There was a problem hiding this comment.
Require hidden-state assertion in form-reset case
The updated form-reset prompt asks the agent to verify validation errors are hidden, but this matcher only requires mentioning form-errors/full-name-error/Required. A plan like is visible 'id="form-errors"' would still pass while asserting the opposite behavior, which weakens this regression and can mask incorrect command-planning output. The assertion should require a hidden/absent check (for example is hidden or wait hidden) rather than bare token presence.
Useful? React with 👍 / 👎.
a0444ba to
b605c83
Compare
b605c83 to
5ffc7d3
Compare
Summary
Updates agent-facing guidance to reflect the current versioned-CLI-help source-of-truth model and the dogfood findings around iOS Expo Go, keyboard dismissal, field clearing, and same-session command ordering.
Specific changes:
agent-device help workflow/help dogfoodthe primary place for workflow guidance.skills/**/SKILL.mdas thin routers only: version gate, read the matching CLI help topic, then follow a short default loop. Behavior-specific guidance stays in CLI help so agents without the skill get the same instructions.agent-device open "Expo Go" <url> --platform ioswhen the host shell is known, then verify withsnapshot -iso agents do not stop on the runner splash.keyboard dismissbehavior as best-effort with explicitUNSUPPORTED_OPERATIONfallback guidance.fill <target> ""is not a supported clear-field command; agents should use visible clear/reset controls or report the tool gap.AGENTS.md, and CLI help assertions with the new guidance.Touched files: 10. Scope stayed within guidance, docs, and SkillGym planning tests.
Validation