Skip to content

fix: update help guidance around Expo Go, keyboard, fill, and parallel commands#467

Merged
thymikee merged 1 commit intomainfrom
docs/update-agent-device-guidance
Apr 28, 2026
Merged

fix: update help guidance around Expo Go, keyboard, fill, and parallel commands#467
thymikee merged 1 commit intomainfrom
docs/update-agent-device-guidance

Conversation

@thymikee
Copy link
Copy Markdown
Contributor

@thymikee thymikee commented Apr 28, 2026

Summary

Updates agent-facing guidance to reflect the current versioned-CLI-help source-of-truth model and the dogfood findings around iOS Expo Go, keyboard dismissal, field clearing, and same-session command ordering.

Specific changes:

  • Makes agent-device help workflow / help dogfood the primary place for workflow guidance.
  • Keeps skills/**/SKILL.md as thin routers only: version gate, read the matching CLI help topic, then follow a short default loop. Behavior-specific guidance stays in CLI help so agents without the skill get the same instructions.
  • Documents iOS Expo Go guidance: prefer agent-device open "Expo Go" <url> --platform ios when the host shell is known, then verify with snapshot -i so agents do not stop on the runner splash.
  • Documents current iOS keyboard dismiss behavior as best-effort with explicit UNSUPPORTED_OPERATION fallback guidance.
  • Documents that fill <target> "" is not a supported clear-field command; agents should use visible clear/reset controls or report the tool gap.
  • Documents that mutating commands against one session must run serially; only read-only commands or separate sessions/devices should be parallelized.
  • Adds/updates SkillGym regression cases for Expo Go host-shell launch, runner-splash recovery, iOS keyboard fallback, empty-fill avoidance, form reset verification, product quantity reads, alert post-dismiss verification, single-command swipe planning, and same-session mutation ordering.
  • Aligns website docs, AGENTS.md, and CLI help assertions with the new guidance.

Touched files: 10. Scope stayed within guidance, docs, and SkillGym planning tests.

Validation

  • pnpm format
  • pnpm exec vitest run src/utils/tests/args.test.ts
  • pnpm check:quick
  • pnpm build
  • SkillGym cases run in batches of 20/20/20/9 via repeated --case runs; all 69 cases passed on codex-mini and claude-haiku
  • Post-AGENTS.md sentinel SkillGym cases passed on codex-mini and claude-haiku:
    • expo-go-ios-project-url
    • same-session-mutations-serial
  • Review follow-up validation:
    • pnpm format
    • pnpm exec vitest run src/utils/tests/args.test.ts
    • pnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --case same-session-mutations-serial
    • pnpm check:quick
    • git diff --check
  • Cleanup validation:
    • pnpm format
    • pnpm exec vitest run src/utils/tests/args.test.ts
    • pnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --case expo-go-ios-project-url
    • pnpm check:quick
    • git diff --check
  • Thin-skill-router follow-up:
    • pnpm format
    • git diff --check

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-28 21:08 UTC

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86f5469a25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

outputs: [
/reset-form/i,
/Form cleared/i,
/(?:form-errors|full-name-error|Required)/i,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require hidden-state assertion in form-reset case

The updated form-reset prompt asks the agent to verify validation errors are hidden, but this matcher only requires mentioning form-errors/full-name-error/Required. A plan like is visible 'id="form-errors"' would still pass while asserting the opposite behavior, which weakens this regression and can mask incorrect command-planning output. The assertion should require a hidden/absent check (for example is hidden or wait hidden) rather than bare token presence.

Useful? React with 👍 / 👎.

@thymikee thymikee force-pushed the docs/update-agent-device-guidance branch 2 times, most recently from a0444ba to b605c83 Compare April 28, 2026 20:57
@thymikee thymikee changed the title docs: update agent-device guidance fix: update help guidance around Expo Go, keyboard, fill, and parallel commands Apr 28, 2026
@thymikee thymikee force-pushed the docs/update-agent-device-guidance branch from b605c83 to 5ffc7d3 Compare April 28, 2026 21:04
@thymikee thymikee merged commit 6c368bf into main Apr 28, 2026
17 of 18 checks passed
@thymikee thymikee deleted the docs/update-agent-device-guidance branch April 28, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant